Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Module Name] It should be a bug introduced by refactoring #1669

Closed
3 of 15 tasks
Armandwt opened this issue Jun 26, 2024 · 0 comments · Fixed by #1672
Closed
3 of 15 tasks

[Bug] [Module Name] It should be a bug introduced by refactoring #1669

Armandwt opened this issue Jun 26, 2024 · 0 comments · Fixed by #1672
Labels
bug Something isn't working Waiting for reply

Comments

@Armandwt
Copy link
Contributor

Armandwt commented Jun 26, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Operating system information

Linux

Python version information

=3.11

DB-GPT version

latest release

Related scenes

  • Chat Data
  • Chat Excel
  • Chat DB
  • Chat Knowledge
  • Model Management
  • Dashboard
  • Plugins

Installation Information

Device information

nothing

Models information

nothing

What happened

1、新版分重构的不干净。
0.5.8版本中以及main分支中(截止该issue提出时刻)。
dbgpt/app/knowlege/service.py中第223行,调用了未被定义的方法_sync_knowledge_document。
image
2、chroma库标量过滤,需要给的入参格式是 {"$and": [{"field_a":1, "filed_b": 2}]},我们代码dbgpt/storage/vector_store/chroma_store.py 第198行的实现需要调整一下
image
现在的逻辑解析出来的格式是{"$FilterCondition.AND": [{"field_a":1, "filed_b": 2}]}
3、chroma向量库召回数据的score计算,重构前langchain的实现如下图,代码位置langchain/schema/vectorstore.py253行
image
重构后丢失了评分的计算,重构后的代码位置dbgpt/storage/vector_store/chroma_store.py 第136行
image
4、document的mysql表操作没有及时close链接,导致当并发高时,会出现链接不可用
代码位置dbgpt/app/knowledge/document_db.py第221行和第255行
image

What you expected to happen

nothing

How to reproduce

nothing

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Armandwt Armandwt added bug Something isn't working Waiting for reply labels Jun 26, 2024
Armandwt pushed a commit to Armandwt/DB-GPT that referenced this issue Jun 27, 2024
fangyinc pushed a commit that referenced this issue Jun 28, 2024
Co-authored-by: WangTing <wangting@192.168.1.10>
Co-authored-by: aries_ckt <916701291@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Waiting for reply
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant