feat(language-selector): add vuestic-language-selector component #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevdyko
force-pushed
the
add-language-selector
branch
5 times, most recently
from
1791acf
to
5f0c978
Compare
|
@yevdyko language selection is empty on initial page load. Also, selected language shall be green when dd is shown |
yevdyko
force-pushed
the
add-language-selector
branch
2 times, most recently
from
7e96a7b
to
e12fdcf
Compare
|
@smartapant What about mobile screens? Should dropdown look like the desktop one or like other dropdowns in navbar? |
|
@smartapant Should we use a fixed dropdown width or relative depending on the item text? |
|
@yevdyko you could use min/max widths. As for mobile view - asked the designer. Will update you |
yevdyko
force-pushed
the
add-language-selector
branch
4 times, most recently
from
3544581
to
baede39
Compare
- Add vuestic-language-selector component - Remove Change Language section from User Profile dropdown in navbar - Add vuestic-language-selector to navbar. - Add flag-icon-css library for country flags in SVG
yevdyko
force-pushed
the
add-language-selector
branch
from
baede39
to
76cbf7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
language-selectorcomponent, includes it to navbar and removesChange Languagesection fromUser Profiledropdown in navbar. It usesflag-icon-csslibrary for country flags in SVG.