Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(library-builder): builder #3609

Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d195f17
feat(library-builder): init builder
m0ksem Jul 11, 2023
b49d3f8
feat(library-builder): web-components
m0ksem Jul 11, 2023
d2a3f19
feat(library-builder): types and css build
m0ksem Jul 11, 2023
d5c1e88
feat(library-builder): add package.json exports
m0ksem Jul 11, 2023
c48c5f0
feat(library-builder): init build CLI
m0ksem Jul 11, 2023
84d1f0f
feat(library-builder): pretty stdio
m0ksem Jul 11, 2023
b9ee65b
raw
m0ksem Jul 11, 2023
9970779
feat(library-builder): nuxt module builder
m0ksem Jul 11, 2023
d8f69f9
feat(library-builder): add nuxtDir argument
m0ksem Jul 11, 2023
f020b64
feat(library-builder): nuxt module builder with runtime dir
m0ksem Jul 12, 2023
1d15df4
chore(library-builder): typo changes
m0ksem Jul 12, 2023
be49322
chore(library-builder): update readme
m0ksem Jul 12, 2023
ca1b8eb
chore: use library builder in ui package
m0ksem Jul 12, 2023
c301693
fix(library-builder): correct vuestic build
m0ksem Jul 14, 2023
2ffb480
feat(library-builder): check if nuxt and styles exists
m0ksem Jul 21, 2023
b86f330
feat(library-builder): resolve exports
m0ksem Jul 21, 2023
909fa87
feat(library-builder): meta builder
m0ksem Jul 24, 2023
927f03d
fix: correct external handling in vite builds
m0ksem Aug 9, 2023
6d8500a
chore: rename bin command
m0ksem Aug 9, 2023
166173d
chore: added build args
m0ksem Aug 9, 2023
d0ab1f3
fix: build target even if there is no argument
m0ksem Aug 9, 2023
0f6842c
chore: added prepack command
m0ksem Aug 9, 2023
5c88dcb
chore: alpha1
m0ksem Aug 9, 2023
1b86812
chore: alpha release
m0ksem Sep 5, 2023
17a7646
fix: suppress extra warnings
m0ksem Nov 7, 2023
81f338a
feat(library-builder): add lodash vite plugin
pogrib0k Nov 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(library-builder): check if nuxt and styles exists
  • Loading branch information
m0ksem committed Jul 21, 2023
commit 2ffb480b62dd608a4ff4f007fe26aa5dc337a858
5 changes: 3 additions & 2 deletions packages/library-builder/src/builder/build-nuxt.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { existsSync } from 'fs'
import { join } from 'pathe'
import { buildNuxtModule } from '../nuxt/builder'
import { strictResolve } from '../utils/strict-resolve'


export const buildNuxt = async (options: {
Expand All @@ -11,9 +12,9 @@ export const buildNuxt = async (options: {
}) => {
const { cwd, outDir, nuxtDir, entry } = options

const nuxtModulePath = join(cwd, nuxtDir)
const nuxtModulePath = strictResolve(cwd, nuxtDir)

if (!existsSync(nuxtModulePath)) {
if (!nuxtModulePath) {
console.warn('Skipping building nuxt module, because it does not exist in ' + nuxtModulePath)
return
}
Expand Down
148 changes: 65 additions & 83 deletions packages/library-builder/src/builder/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,119 +34,101 @@ export const build = async (options: {

cleanDist(outDir)

const tasks: Promise<unknown>[] = []

if (targets.includes('es')) {
// tasks.push(
console.log('Building ES module')
await buildVite(createViteConfig({
format: 'es',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
// )
console.log('Building ES module')
await buildVite(createViteConfig({
format: 'es',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
}

if (targets.includes('esm-node')) {
// tasks.push(
console.log('Building ESM node module')
await buildVite(createViteConfig({
format: 'esm-node',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
// )
console.log('Building ESM node module')
await buildVite(createViteConfig({
format: 'esm-node',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
}

if (targets.includes('cjs')) {
// tasks.push(
console.log('Building CommonJS module')
await buildVite(createViteConfig({
format: 'cjs',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
// )

console.log('Building CommonJS module')
await buildVite(createViteConfig({
format: 'cjs',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
}

if (targets.includes('iife')) {
// tasks.push(
console.log('Building IIFE module')
await buildVite(createViteConfig({
format: 'iife',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
// )
console.log('Building IIFE module')
await buildVite(createViteConfig({
format: 'iife',
entry: entry,
cwd: cwd,
outDir: outDir,
}))
}

if (targets.includes('web-components')) {
console.log('Web components build is experimental')
console.log('Building web components')

// tasks.push(
await buildVite(createWebComponentsViteConfig({
cwd: cwd,
outDir: outDir,
entry: entry,
}))
// )
await buildVite(createWebComponentsViteConfig({
cwd: cwd,
outDir: outDir,
entry: entry,
}))
}

if (targets.includes('types')) {
console.log('Building types')
// tasks.push(
await buildTypes({
cwd: cwd,
outDir: outDir,
})
// )
await buildTypes({
cwd: cwd,
outDir: outDir,
})
}

if (targets.includes('nuxt')) {
console.log('Building Nuxt module')
// tasks.push(
await buildNuxt({
cwd,
entry,
outDir,
nuxtDir
})
// )
await buildNuxt({
cwd,
entry,
outDir,
nuxtDir
})
}

if (targets.includes('styles')) {
console.log('Building styles')

await buildVite(
createStylesViteConfig({
cwd: cwd,
entry: entry,
outDir: outDir,
})
)
const stylesViteConfig = createStylesViteConfig({
cwd: cwd,
entry: entry,
outDir: outDir,
})

if (stylesViteConfig) {
await buildVite(
stylesViteConfig
)
}
}

// return promiseSequence(tasks)
// .then((r) =>{
await generateExports({ cwd, entry, outDir, targets, append: true })

await postBuild({
cwd: cwd,
entry: entry,
outDir: outDir,
targets: targets,
})

console.log('Build finished')
// }).catch((error) => {
// console.log('Build failed')
// console.error(error)
// // TODO: handle error?
// })
await generateExports({ cwd, entry, outDir, targets, append: true })

await postBuild({
cwd: cwd,
entry: entry,
outDir: outDir,
targets: targets,
})

console.log('Build finished')
})
}
11 changes: 7 additions & 4 deletions packages/library-builder/src/nuxt/builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ export async function buildNuxtModule(options: {
...Object.keys(packageJson.peerDependencies || {}),
]

console.log('Building Nuxt module...', packageJson.name)

if (packageJson.name) {
dependencies.push(packageJson.name);
}
Expand All @@ -35,9 +33,14 @@ export async function buildNuxtModule(options: {
[packageJson.name]: [join(options.cwd, options.entry)],
} : {}
})
await buildVite(nuxtRuntimeDirViteConfig({

const runtimeViteConfig = nuxtRuntimeDirViteConfig({
entryDir: resolve(options.cwd, options.nuxtDir, "runtime"),
outDir: join(outDir, "runtime"),
external: dependencies,
}))
})

if (runtimeViteConfig) {
await buildVite(runtimeViteConfig)
}
}
10 changes: 9 additions & 1 deletion packages/library-builder/src/nuxt/runtime-builder.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
import { readDirRecursive } from './../utils/read-dir-recursive';
import { defineViteConfig } from "../utils/define-vite-config";
import { replaceNext } from '../plugins/replace-next';
import { strictResolve } from '../utils/strict-resolve';

export const nuxtRuntimeDirViteConfig = (options: {
entryDir: string,
outDir: string
external?: string[],
}) => {
const inputs = readDirRecursive(options.entryDir)
const nuxtDir = strictResolve(options.entryDir)

if (!nuxtDir) {
return
}

const inputs = readDirRecursive(nuxtDir)

const { external = [], entryDir, outDir } = options

Expand All @@ -34,6 +41,7 @@ export const nuxtRuntimeDirViteConfig = (options: {
return true
}

console.log('external', source)
if (external.includes(source)) {
return true
}
Expand Down
17 changes: 17 additions & 0 deletions packages/library-builder/src/utils/strict-resolve.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { resolve } from "pathe"
import { existsSync } from 'fs'

/**
* Return
* @param args
* @returns
*/
export const strictResolve = (...args: string[]) => {
const path = resolve(...args)

if (!existsSync(path)) {
return undefined
}

return path
}
10 changes: 9 additions & 1 deletion packages/library-builder/src/vite/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { rmSync, statSync } from 'fs';
import { defineViteConfig } from '../utils/define-vite-config'
import { readDirRecursive } from '../utils/read-dir-recursive'
import { dirname, join, } from 'pathe'
import { strictResolve } from '../utils/strict-resolve';

export const createStylesViteConfig = (options: {
cwd: string,
Expand All @@ -11,7 +12,14 @@ export const createStylesViteConfig = (options: {
}) => {
const { cwd, entry, outDir } = options

const cssInputs = readDirRecursive(join(cwd, dirname(entry), 'styles'))
const entryDir = strictResolve(cwd, dirname(entry), 'styles')

if (!entryDir) {
console.log('Skipping building styles, because styles directory does not exist')
return
}

const cssInputs = readDirRecursive(entryDir)
.filter((el) => ['.css', '.scss']
.some((elem) => el.includes(elem) && !el.includes('/_')))

Expand Down