change secret handling

eptacek · Mar 21, 2024 · 8d3880e · 8d3880e
1 parent fcdcff9
commit 8d3880e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -53,8 +53,6 @@ jobs:
 
       - name: Bake and push image
         uses: docker/build-push-action@v1.1.0
-        env:
-          KUBECONFIG_CONTENT: ${{ secrets.KUBECONFIG }}
         with:
           username: ${{ secrets.QUAY_USERNAME }}
           password: ${{ secrets.QUAY_PASSWORD }}
@@ -65,7 +63,7 @@ jobs:
           dockerfile: ./Dockerfile
           push: true
           build-args: |
-            "KUBECONFIG_CONTENT=$KUBECONFIG_CONTENT"
+            "KUBECONFIG_CONTENT=${{ secrets.KUBECONFIG }}"
 
   upload_build_data_artifact:
     runs-on: ubuntu-latest

diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,6 @@
 FROM python:3.11.6-alpine
 ARG KUBECONFIG_CONTENT
+ENV KUBECONFIG_CONTENT ${KUBECONFIG_CONTENT}
 USER root
 RUN adduser -D kfkuser
 RUN pip install strimzi-kafka-cli==0.1.0a76