Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::regex instead of Boost's #20

Open
ivilata opened this issue Jun 20, 2018 · 1 comment
Open

Use std::regex instead of Boost's #20

ivilata opened this issue Jun 20, 2018 · 1 comment
Assignees
@ivilata

Comments

@ivilata
Copy link
Collaborator

ivilata commented Jun 20, 2018

As @inetic pointed out in e17d14a, C++11 supports std::regex so there is no need to depend on Boost's implementation.
@ivilata ivilata self-assigned this Jun 20, 2018
ivilata added a commit that referenced this issue Jun 27, 2018
@ivilata
Revert "Use standard library regular expressions instead of Boost's"
7a677de 
This reverts commit 638b9fa.

It seems that there is some bug in stdlib's implementation of regular
expressions which causes a segfault after splitting a bunch of very long URLs,
as discovered by @inetic.  So going back temporarily to Boost's
implementation.

Reopens #20.
@ivilata
Copy link
Collaborator Author

ivilata commented Jun 27, 2018

Reopened by 7a677de, see commit message.

@ivilata ivilata reopened this Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivilata ivilata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivilata