Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for build-android.sh #58

Open
paidforby opened this issue Feb 13, 2023 · 0 comments
Open

Remove need for build-android.sh #58

paidforby opened this issue Feb 13, 2023 · 0 comments

Comments

@paidforby
Copy link
Contributor

It should be possible to build the ouinet AAR without the need for a shell script that wraps the gradle scripts. Gradle is a fully featured scripting language intended specifically for compiling code, there should not be any need to wrap it in a shell script. We might still want portions of the "bootstrap" task from shell script, but that would only need to be run once when first setting up a development machine.

  • Compile target and min sdks should move to a buildSrc or a plugin dependencies directory, there are some notes on the sdk variables in android-sdk-versions

  • Build and publish all abis at the same time by default, no need to specify or loop over the script, unless you want to.

  • Get versionNumber from version.txt, this is already done in one part of the gradle scripts, but not others.

  • buildId, just equals branch name, probably easily write this into gradle

  • The setting below could possibly be set elsewhere, e.g. in local properties? or gradle properties.

--project-dir="${ROOT}"/android \
--gradle-user-home "${DIR}"/_gradle-home \
--project-cache-dir "${GRADLE_BUILDDIR}"/_gradle-cache \
paidforby added a commit that referenced this issue Feb 17, 2023
…h git-version-string.gradle instead of shell script, related to #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant