Wrapper #12
Open
Wrapper #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrizzle
reviewed
Oct 17, 2023
| Token6 public immutable USDC; // solhint-disable-line var-name-mixedcase | ||
|
|
||
| /// @dev Batcher address | ||
| ITwoWayBatcher public batcher; |
There was a problem hiding this comment.
I'm thinking maybe we should just make this immutable as well since we'll have to change the batcher-related code for different batcher implementations, so it will require a redeploy either way.
Maybe we should add a better interface to the batchers so we don't need to do that in the future 😓 .
There was a problem hiding this comment.
What if we deploy a wrapper before a batcher?
Unit Test Coverage ReportCoverage after merging fennel/wrapper into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Integration Test Coverage ReportCoverage after merging fennel/wrapper into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.