Fix bash command filepaths (README.md), add bn.js dependency (package.json), add feature (fetchFormatMakerData.ts) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bash commands by updating filename from fetchMakerData.ts to fetchFormatMakerData.ts and relative path from ./examples/ to ./examples/onchain/
Add dependency "bn.js": "^5.2.1"
Check for environment variable USER_ADDRESS to fetch Maker position data for a specific user. If USER_ADDRESS does not exist, revert back to the previous behaviour using zeroAddress as the input for calling main()
1) Add instructions how to fetch Maker data for specific user address 2) Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bash commands in README.md that had deprecated filenames and filepaths
Added bn.js dependency because it was not possible to run the example scripts without that (Error: Cannot find module 'bn.js')
Added a feature to get Maker position data for a specific user address. This was only possible before by modifying the fetchFormatMakerData.ts file and replacing "zeroAddress" with whatever address the user is interested in. With the small change proposed in this pull request, it will be possible to specify an environment variable called USER_ADDRESS instead.