Fix issue with settle() asyncFee is left in the KeepFactory and is not transfer to the keeper #1928
Triggered via pull request
October 11, 2024 15:17
EdNoepel
Status
Success
Total duration
1h 52m 45s
Artifacts
16
CI.yml
on: pull_request
[Core] Unit Tests w/ Coverage
1h 52m
[Core] Integration Tests w/ Coverage
41m 54s
[Collateral Accounts] Integration Tests w/ Coverage
4m 13s
[Oracle] Integration Tests w/ Coverage
29m 15s
[Oracle] Sepolia Integration Tests w/ Coverage
4m 4s
[Trigger Orders] Integration Tests w/ Coverage
14m 15s
[Vault] Integration Tests w/ Coverage
1h 9m
[Extensions] Integration Tests w/ Coverage
43m 59s
[Collateral Accounts] Unit Tests w/ Coverage
2m 29s
[Oracle] Unit Tests w/ Coverage
3m 30s
[Trigger Orders] Unit Tests w/ Coverage
2m 21s
[Vault] Unit Tests w/ Coverage
2m 17s
[Extensions] Unit Tests w/ Coverage
19m 21s
[Verifier] Unit Tests w/ Coverage
2m 5s
Lint
1m 7s
[Core] Combined Tests w/ Coverage
20s
Periphery Combined Tests Coverage
31s
Annotations
36 warnings
|
Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint
Code contains empty blocks
|
|
Lint
Contract name must be in CamelCase
|
|
Lint
Code contains empty blocks
|
|
Lint
Contract name must be in CamelCase
|
|
Lint
Explicitly mark visibility of state
|
|
Lint
Explicitly mark visibility of state
|
|
Lint
Explicitly mark visibility of state
|
|
Lint
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint:
packages/perennial-deploy/deploy/004_deploy_market.ts#L1
'utils' is defined but never used
|
|
Lint:
packages/perennial-deploy/deploy/005_deploy_vault.ts#L14
'isTestnet' is defined but never used
|
|
[Verifier] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Vault] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Trigger Orders] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Collateral Accounts] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Oracle] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Oracle] Sepolia Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Collateral Accounts] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Trigger Orders] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Extensions] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Periphery Unit Tests Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Periphery Unit Tests Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Oracle] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Core] Integration Tests w/ Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
[Core] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Extensions] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Vault] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Periphery Integration Tests Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Periphery Integration Tests Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Periphery Combined Tests Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Periphery Combined Tests Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Core] Unit Tests w/ Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
[Core] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
[Core] Combined Tests w/ Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
[Core] Combined Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "account_integration_test_coverage", "account_unit_test_coverage", "core_integration_test_coverage", "core_unit_test_coverage", "extensions_integration_test_coverage", "extensions_unit_test_coverage", "oracle_integration_test_coverage", "oracle_sepolia_integration_test_coverage", "oracle_unit_test_coverage", "order_integration_test_coverage", "order_unit_test_coverage", "periphery_integration_coverage", "periphery_unit_coverage", "vault_integration_test_coverage", "vault_unit_test_coverage", "verifier_unit_test_coverage".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
account_integration_test_coverage
|
10.6 KB |
|
|
account_unit_test_coverage
|
10.5 KB |
|
|
core_integration_test_coverage
|
26.8 KB |
|
|
core_unit_test_coverage
|
27.1 KB |
|
|
extensions_integration_test_coverage
|
6.77 KB |
|
|
extensions_unit_test_coverage
|
6.74 KB |
|
|
oracle_integration_test_coverage
|
13.2 KB |
|
|
oracle_sepolia_integration_test_coverage
|
12.8 KB |
|
|
oracle_unit_test_coverage
|
12.8 KB |
|
|
order_integration_test_coverage
|
5.74 KB |
|
|
order_unit_test_coverage
|
5.63 KB |
|
|
periphery_integration_coverage
|
30.9 KB |
|
|
periphery_unit_coverage
|
31 KB |
|
|
vault_integration_test_coverage
|
9.2 KB |
|
|
vault_unit_test_coverage
|
8.35 KB |
|
|
verifier_unit_test_coverage
|
1.81 KB |
|