Skip to content

v2.3 Audit Fixes

v2.3 Audit Fixes #1945

Triggered via pull request October 16, 2024 02:03
Status Success
Total duration 1h 53m 26s
Artifacts 16

CI.yml

on: pull_request
[Core] Unit Tests w/ Coverage
1h 52m
[Core] Unit Tests w/ Coverage
[Core] Integration Tests w/ Coverage
31m 38s
[Core] Integration Tests w/ Coverage
[Collateral Accounts] Integration Tests w/ Coverage
4m 19s
[Collateral Accounts] Integration Tests w/ Coverage
[Oracle] Integration Tests w/ Coverage
28m 4s
[Oracle] Integration Tests w/ Coverage
[Oracle] Sepolia Integration Tests w/ Coverage
4m 7s
[Oracle] Sepolia Integration Tests w/ Coverage
[Trigger Orders] Integration Tests w/ Coverage
14m 33s
[Trigger Orders] Integration Tests w/ Coverage
[Vault] Integration Tests w/ Coverage
1h 12m
[Vault] Integration Tests w/ Coverage
[Extensions] Integration Tests w/ Coverage
44m 17s
[Extensions] Integration Tests w/ Coverage
[Collateral Accounts] Unit Tests w/ Coverage
2m 28s
[Collateral Accounts] Unit Tests w/ Coverage
[Oracle] Unit Tests w/ Coverage
3m 15s
[Oracle] Unit Tests w/ Coverage
[Trigger Orders] Unit Tests w/ Coverage
2m 20s
[Trigger Orders] Unit Tests w/ Coverage
[Vault] Unit Tests w/ Coverage
2m 25s
[Vault] Unit Tests w/ Coverage
[Extensions] Unit Tests w/ Coverage
20m 26s
[Extensions] Unit Tests w/ Coverage
[Verifier] Unit Tests w/ Coverage
2m 8s
[Verifier] Unit Tests w/ Coverage
[Core] Combined Tests w/ Coverage
15s
[Core] Combined Tests w/ Coverage
Periphery Integration Tests Coverage
41s
Periphery Integration Tests Coverage
Periphery Unit Tests Coverage
23s
Periphery Unit Tests Coverage
Periphery Combined Tests Coverage
17s
Periphery Combined Tests Coverage
Fit to window
Zoom out
Zoom in

Annotations

36 warnings
Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint
Contract name must be in CamelCase
Lint
Code contains empty blocks
Lint
Contract name must be in CamelCase
Lint
Explicitly mark visibility of state
Lint
Explicitly mark visibility of state
Lint
Explicitly mark visibility of state
Lint
Avoid to use inline assembly. It is acceptable only in rare cases
Lint: packages/perennial-deploy/deploy/004_deploy_market.ts#L1
'utils' is defined but never used
Lint: packages/perennial-deploy/deploy/005_deploy_vault.ts#L14
'isTestnet' is defined but never used
Lint: packages/perennial-deploy/test/verification/arbitrum/perennial/verifyMarkets.test.ts#L16
'GAUNTLET_ADDRESS' is assigned a value but never used
[Verifier] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Trigger Orders] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Vault] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Collateral Accounts] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Oracle] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Oracle] Sepolia Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Collateral Accounts] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Trigger Orders] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Extensions] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Periphery Unit Tests Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Periphery Unit Tests Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Oracle] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Core] Integration Tests w/ Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
[Core] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Extensions] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Vault] Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Periphery Integration Tests Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Periphery Integration Tests Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Periphery Combined Tests Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Periphery Combined Tests Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Core] Unit Tests w/ Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
[Core] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Core] Combined Tests w/ Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
[Core] Combined Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/download-artifact@v3, romeovs/lcov-reporter-action@v0.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "account_integration_test_coverage", "account_unit_test_coverage", "core_integration_test_coverage", "core_unit_test_coverage", "extensions_integration_test_coverage", "extensions_unit_test_coverage", "oracle_integration_test_coverage", "oracle_sepolia_integration_test_coverage", "oracle_unit_test_coverage", "order_integration_test_coverage", "order_unit_test_coverage", "periphery_integration_coverage", "periphery_unit_coverage", "vault_integration_test_coverage", "vault_unit_test_coverage", "verifier_unit_test_coverage". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
account_integration_test_coverage
10.5 KB
account_unit_test_coverage
10.4 KB
core_integration_test_coverage
27 KB
core_unit_test_coverage
27.3 KB
extensions_integration_test_coverage
6.77 KB
extensions_unit_test_coverage
6.74 KB
oracle_integration_test_coverage
13.2 KB
oracle_sepolia_integration_test_coverage
12.8 KB
oracle_unit_test_coverage
12.8 KB
order_integration_test_coverage
5.72 KB
order_unit_test_coverage
5.61 KB
periphery_integration_coverage
30.7 KB
periphery_unit_coverage
30.9 KB
vault_integration_test_coverage
9.2 KB
vault_unit_test_coverage
8.35 KB
verifier_unit_test_coverage
2.13 KB