Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use model hull to steer node/connection generation #128

Merged
merged 11 commits into from
Aug 24, 2020

Conversation

wouterjdb
Copy link
Contributor

Closes #124.

Three new options can be specified in the config:

data_sources:
  concave_hull: True

Which limits new nodes to the volume of the original simulation model.
And,

flownet:
  max_distance: 1000
  max_distance_fraction: 0.15

Which limits the max length of connections after doing the Delaunay triangulation which created the connections.

The resulting FlowNet model for Norne now looks like:
image

@wouterjdb wouterjdb added the enhancement New feature or request label Aug 21, 2020
@wouterjdb wouterjdb self-assigned this Aug 21, 2020
@wouterjdb
Copy link
Contributor Author

@anders-kiaer I removed mypy from the tests as it didn't like my faking of the config. I actually vote for not using mypy in the tests.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to consider, otherwise LVGTM! 🚀🌻

tests/test_generate_connections.py Outdated Show resolved Hide resolved
@wouterjdb wouterjdb merged commit 0f11804 into equinor:master Aug 24, 2020
@wouterjdb wouterjdb deleted the i124-concave-hull branch August 24, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hull from simulation model
2 participants