Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug where the analytics module would fail for iterations > 9 #346

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Fixes bug where the analytics module would fail for iterations > 9 #346

merged 2 commits into from
Mar 3, 2021

Conversation

edubarrosTNO
Copy link
Contributor

@edubarrosTNO edubarrosTNO commented Mar 3, 2021 •
edited
Loading

Fixes bug where the analytics module would fail for iterations larger than 9 (i.e., iteration number with two or more digits)

Contributor checklist

  • 🎉 This PR closes no open issue.
  • 📜 I have broken down my PR into the following tasks:
    • Fix make_dataframe_simulation_data function in _ahm_iteration_analytics.py.
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@edubarrosTNO
Fixes bug where the analytics module would fail for iterations larger…
65e2265 
… than 9 (i.e., iteration number with two or more digits)
@edubarrosTNO edubarrosTNO added the bug Something isn't working label Mar 3, 2021
wouterjdb
wouterjdb approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@wouterjdb wouterjdb merged commit b27b041 into equinor:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

@olelod olelod Awaiting requested review from olelod olelod is a code owner

Assignees

@edubarrosTNO edubarrosTNO

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edubarrosTNO @wouterjdb