Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple plotting tool #351

Merged
merged 15 commits into from
Mar 11, 2021
Merged

Add simple plotting tool #351

merged 15 commits into from
Mar 11, 2021

Conversation

wouterjdb
Copy link
Contributor

@wouterjdb wouterjdb commented Mar 5, 2021 •
edited
Loading

This PR adds a simple plotting tool which allows you to plot the results of FlowNet runs.

Contributor checklist

  • 🎉 This PR closes Speed up plotting #148
  • 📜 I have broken down my PR into the following tasks:
    • Add initial version of the tool
    • Make more updates
    • Add observations
    • Add support for multiple vertical lines
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added the enhancement New feature or request label Mar 5, 2021
@wouterjdb wouterjdb self-assigned this Mar 5, 2021
@wouterjdb wouterjdb marked this pull request as ready for review March 10, 2021 12:24
@wouterjdb wouterjdb mentioned this pull request Mar 10, 2021
Open
LonnekevB
LonnekevB suggested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@LonnekevB LonnekevB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions on making the help a bit more explicit.

src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
olelod
olelod requested changes Mar 10, 2021
View reviewed changes
src/flownet/utils/plot_results.py Show resolved Hide resolved
src/flownet/utils/plot_results.py Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
src/flownet/utils/plot_results.py Outdated Show resolved Hide resolved
@wouterjdb
Copy link
Contributor Author

Example from @edubarrosTNO

image

@wouterjdb wouterjdb requested a review from olelod March 11, 2021 08:16
olelod
olelod approved these changes Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@olelod olelod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wouterjdb wouterjdb merged commit 8510c85 into equinor:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olelod olelod olelod approved these changes

@LonnekevB LonnekevB LonnekevB approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@wouterjdb wouterjdb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up plotting
3 participants
@wouterjdb @olelod @LonnekevB