Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make regional multipliers for bulkvolume, porosity and permeability #404

Merged
merged 12 commits into from
May 28, 2021

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented May 11, 2021

This PR introduces the possibility of adding regional multipliers for bulkvolume, permeability and porosity.


Contributor checklist

  • 🎉 This PR closes Regional (or trend) tuning parameters #394.
  • 📜 I have broken down my PR into the following tasks:
    • Add bulkvolume_mult_regional_scheme, porosity_regional_scheme and permeability_regional_scheme to the model_parameters in _config_parser.py. Default values are individual, meaning no regional multiplier (alternatives are regions_from_sim or global)
    • Add bulkvolume_mult_regional, porosity_regional and permeability_regional to the model_parameters in _config_parser.py. If the *_regional_scheme is individual the priors can be empty, otherwise they need to be defined (same way as the priors for individual tubes - not implemented possibility for different priors in different regions (such as for equilibrium regions or relative permeability)
    • Add bulkvolume_mult_parameter_from_sim_model, porosity_parameter_from_sim_model and permeability_parameter_from_sim_model, telling which region parameter to look for in the input simulation model if the *_regional_scheme is set to regions_from_sim.
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added the enhancement New feature or request label May 11, 2021
@olelod olelod marked this pull request as ready for review May 20, 2021 07:33
Copy link
Contributor

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Don't forget to change back the test-data pointer.

src/flownet/parameters/_porv_poro_trans.py Outdated Show resolved Hide resolved
.github/workflows/flownet.yml Show resolved Hide resolved
.github/workflows/flownet.yml Outdated Show resolved Hide resolved
@wouterjdb wouterjdb merged commit 59cf659 into equinor:master May 28, 2021
@olelod olelod deleted the volume-multiplier-per-region branch May 28, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regional (or trend) tuning parameters
2 participants