Removed unnecessary factory class Closes #101 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 718f3f7 into d727f07 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 98.72% 98.71% -0.01%
==========================================
Files 16 16
Lines 2506 2490 -16
==========================================
- Hits 2474 2458 -16
Misses 32 32
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the PyscalFactory class from factory.py such that all the static methods within are now individual functions that can be used and accessed without having reference the PyscalFactory class (all of the references were also removed appropriately).