This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fixes for 37 CFR 42 history #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is likely an error, so we'll still warn the user, but proceeding by skipping the rule is what most users will want.
We've thus far assumed that the first version we'd encounter would be associated with an annual edition of the regulation (meaning we'd have a full tree to start). That's not a safe assumption, so let's remove it, skipping any versions that came before the first annual edition.
We'd like to retry when this rule isn't satisfied. It most likely means something went wrong, but given the complexity of the "stars" rules, we should try again.
We had been using PRTPAGE tags to deduce the start/end pages within the Federal Register. This wasn't always accurate, but proved to be a true problem when notices had no PRTPAGE tags at all. Instead, we can use the meta data provided by the Federal Register
cmc333333
force-pushed
the
37-42-fixes
branch
from
8dfe4fa
to
b183fe5
Compare
Closed
…into 37-42-fixes
|
Changes Unknown when pulling da0a3d4 on cmc333333:37-42-fixes into ** on eregs:master**. |
|
Open for a bit, I'm going to go ahead and merge. I'll cut a new release, too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves four bugs that were discovered when trying to parse the history of 37 CFR 42. All four are generally applicable and shouldn't cause data regressions (though I'm not crazy confident about the stars_occupy_space rule change).
The last change requires clearing existing docs and changing the input of proposed rules for notice-and-comment slightly. Given that that's still a beta feature, I'm comfortable just bumping the minor version.