Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to learn Go, I was searching for some interesting project to play
with and get some experience on how does it feel to do something real in it.
While browsing through the code, I've noticed that the version of docopt locked
in Gopkg.lock
(https://github.com/oragono/oragono/blob/8e027fb58f4e9cb85cc04f3ca72526e3b4f88d57/Gopkg.lock#L17)
doesn't correspond with the version being vendored.
Compare
https://github.com/docopt/docopt.go/tree/784ddc588536785e7299f7272f39101f7faccc3f
with
https://github.com/oragono/oragono-vendor/tree/77ddc3dbc1ec085c73670510a8fece80599741ce/github.com/docopt/docopt-go
It seemed to me that migrating to Go 1.11's modules might be a way to fix this
and actually get to something that looks like preferred way of dealing with go
deps in 2018.
Please note that this is my first Go contribution and I have more
or less no idea what I'm doing. Feedback welcome. Also, feel free to close the
PR if you're not in favour of this change: no hard feelings.
Steps performed:
go mod init
rm -rf Gopkg.* vendor
go get -u