Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating async package to 3.x results in test failures #12

Closed
ericblade opened this issue Aug 14, 2019 · 1 comment
Closed

updating async package to 3.x results in test failures #12

ericblade opened this issue Aug 14, 2019 · 1 comment
Labels
maintenance

Comments

@ericblade
Copy link
Owner

npm-upgrade async results in test failures
ericblade added a commit that referenced this issue May 2, 2020
@ericblade
fix #12: remove use of async library
db15a3b 
- also remove unintended dependency on @std/esm, esm, ts-node
- async was used to run a bunch of functions in serial, during tests.
  The section has been re-written to use reduce on promises.
@ericblade
Copy link
Owner Author

#184 will remove use of the async library in favor of using built-in Promise handling combined with Array.reduce to replace the use of async.eachSeries

@rollingversions rollingversions bot mentioned this issue May 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericblade