Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating mocha ^6.2.0 fails #15

Closed
ericblade opened this issue Aug 14, 2019 · 2 comments
Closed

updating mocha ^6.2.0 fails #15

ericblade opened this issue Aug 14, 2019 · 2 comments
Labels
dependencies Pull requests that update a dependency file maintenance

Comments

@ericblade
Copy link
Owner

mocha 6+ fails
@ericblade
Copy link
Owner Author

@Domratchev 's large changeset here serratus/quaggaJS@05e6b46#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

also updates mocha, karma, etc to newer versions than i was able to get to without code changes.

@ericblade ericblade added the dependencies Pull requests that update a dependency file label Sep 16, 2019
@ericblade ericblade mentioned this issue May 2, 2020
Closed
@ericblade
Copy link
Owner Author

Mocha 6 requires a newer browser than PhantomJS provides, so we are unable to update any further than 5.x until #75 gets some major traction done on it, at least to the point where it can replace the existing PhantomJS based test suite.

ericblade added a commit that referenced this issue May 3, 2020
@ericblade
upgrade mocha to 5.2.0, this will close #15 pending rebuilding testsuite
e1ae989 
- phantomjs does not support things required to run mocha 6.x or 7.x
@rollingversions rollingversions bot mentioned this issue May 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericblade