Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for incorrect calls to exit() vs returning from a function #23

Closed
ericblade opened this issue Aug 20, 2019 · 0 comments
Closed

check for incorrect calls to exit() vs returning from a function #23

ericblade opened this issue Aug 20, 2019 · 0 comments
Labels
bug help wanted investigation

Comments

@ericblade
Copy link
Owner

see Vyache18/quaggaJS@80ade43

this may be a reason for some issues, it's a bit weird for a library to directly call exit, and things should be reflowed to not do that, and return/throw correctly
ericblade added a commit that referenced this issue Dec 10, 2019
@ericblade
Merge pull request #76 from ericblade/dev
ea91b32 
fix #23: loadImages throws error instead of attempting to call exit()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericblade