[Docs] views::filter and views::ints usage examples #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericniebler
reviewed
Oct 23, 2020
ericniebler
reviewed
Oct 23, 2020
| /// | ||
| /// <pre><b>output_range</b></pre> | ||
| /// - Range of monotonically increasing ints | ||
| /// - When an `upper_bound` is not specified, the range is quasi-infinite |
There was a problem hiding this comment.
Is "quasi-infinite" defined anywhere? What does it mean? What concepts does the resulting range satisfy?
There was a problem hiding this comment.
I based this off of the existing docs "Generate a range of monotonically increasing ints. When used without arguments, it generates the quasi-infinite range". If I'm reading the code correctly, it looks like the iterator will eventually overflow.
Not sure what concepts it satisfies or how to find out. Can you point me to that info?
There was a problem hiding this comment.
All "infinite" ranges have difference types that will eventually overflow. It's a problem with the ranges design I was never able to properly solve.
Dig-Doug
force-pushed
the
filter-docs
branch
from
c452604
to
5de1d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1536.