Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MailChimp to styles library #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisChinchilla
Copy link
Contributor

As with other PR, I cannot figure out the latest zip archive link

library.json Outdated
"name": "MailChimp",
"description": "A Vale-compatible implementation of the MailChimp Style Guide.",
"homepage": "https://github.com/testthedocs/MailChimp",
"url": "https://github.com/errata-ai/Microsoft/releases/latest/download/Microsoft.zip"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be https://github.com/testthedocs/MailChimp/releases/latest/download/MailChimp.zip?
It redirects to https://github.com/testthedocs/MailChimp/archive/0.1.0.zip, but this results in a 404. Accessing this link directly works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this needs fixing, I am doing that tomorrow

See the whole discussion in #5

@ChrisChinchilla
Copy link
Contributor Author

@jdkato MailChimp should also now be ready

@themr0c
Copy link
Contributor

themr0c commented Jul 20, 2022

The assets are missing, https://github.com/testthedocs/MailChimp/releases/latest/download/MailChimp.zip does not exist

@themr0c
Copy link
Contributor

themr0c commented Jul 20, 2022

This could help releasing the required MailChimp.zip testthedocs/MailChimp#3
(There are other ways to do it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants