feat: add comment syntax for ignoring individual matches #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkato
force-pushed
the
v3
branch
4 times, most recently
from
716d7f6
to
40d7e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to turn off rules for specific matches. I was mainly thinking of situations where you may want to check if a word is being used correctly in a paragraph, and then receive no more notifications about it, but still allow other words to be picked up.
This is the syntax I've gone for, where the array can contain one or more matches to disable:
I haven't implemented all the tests yet, looking to get feedback if this is a proper way of solving the problem.