feat(getStaticValue): added more safe calls #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 96.70% 96.89% +0.18%
==========================================
Files 13 13
Lines 2003 2060 +57
Branches 380 382 +2
==========================================
+ Hits 1937 1996 +59
+ Misses 65 63 -2
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ota-meshi
changed the title
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows calls to more safe instance and static methods of arrays, numbers, strings, sets and maps.
"Safe method" means that the method:
thisargument.Maybe more interesting than what safe methods are is what isn't a safe method. Here are a few examples of non-safe methods:
Array#pop: This modifies the array.Array#mapandArray#flatMap: It is possible to create arbirarly large arrays usingmap+flatandflatMap(assuming user-defined function evaluation).String#localeCompare: The result depends on the system the code is executed, so it's not deterministic.String#{match,matchAll,replace,replaceAll,split}: RegExp execution isn't safe because it can take up to exponential time.String#{matchAll,replace,replaceAll,split}: This be used to exponentially grow strings or arrays.I also didn't include any of HTML-creating string methods (e.g
"".big()).