Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add site theme for dark mode #84

Merged
merged 2 commits into from
Mar 22, 2023
Merged

chore(docs): add site theme for dark mode #84

merged 2 commits into from
Mar 22, 2023

Conversation

ota-meshi
Copy link
Member

This PR adds a dark mode theme to the documentation site.

close #83

@ota-meshi ota-meshi requested a review from a team March 20, 2023 00:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (80b934e) 96.93% compared to head (18b8d62) 96.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          13       13           
  Lines        2090     2090           
  Branches      388      388           
=======================================
  Hits         2026     2026           
  Misses         63       63           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RunDevelopment
Copy link

That works wonders! Thank you!

On that note, I also noticed that the green used for the required Node version is quite dark as well. Would it be possible to lighten up that color too?
image

@ota-meshi
Copy link
Member Author

Thank you for pointing out.
But the custom container theme is using the vitepress default theme.
It seems that it is still being improved frequently even now, so I would like to deal with it only if there is a problem even after it becomes GA.
vuejs/vitepress#1989

@RunDevelopment
Copy link

I'll make them an issue.

@ota-meshi
Copy link
Member Author

@RunDevelopment Thank you for checking this PR!

@ota-meshi ota-meshi merged commit fd21933 into main Mar 22, 2023
@ota-meshi ota-meshi deleted the site-theme branch March 22, 2023 01:21
@MichaelDeBoey
Copy link
Member

@ota-meshi Can we have this in our other repos as well please?

@ota-meshi
Copy link
Member Author

ota-meshi commented Mar 23, 2023

We could use the same theme in another repo, but I think eslint-utils and eslint-plugin-es-x are the only repos currently using vitepress on the documentation site. If we also replace vuepress with vitepress in other repo, we can use the same theme.
I will replace vuepress with vitepress when I have time.

@github-actions
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc pages] Consider using a different link color in dark mode
4 participants