don't process JSON past the end of the buffer #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deserializeJson needs size if it's not a zero-terminated string
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer that files are read into is not zero-terminated, but deserializeJson needs a zero-terminated string. It seems that deserializeJson normally stops when it's read a full JSON document hence it usually works fine, but it's possible (especially if a file is corrupt for some reason) that it could keep processing past the end of the file. deserialiseJson accepts an optional buffer size which saves having to extend the buffer for the extra \0 char.
There are some other cases of deserializeJson, but having looked at them it seems to me that they are operating on zero-terminated buffers, so are good as-is.