Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new clock face #1142

Merged
merged 34 commits into from
Jan 4, 2022
Merged

new clock face #1142

merged 34 commits into from
Jan 4, 2022

Conversation

HeiLaut
Copy link
Contributor

@HeiLaut HeiLaut commented Dec 19, 2021

new dark full screen analog clock face (andark)

@myxor
Copy link
Contributor

myxor commented Dec 19, 2021

Is the add_to_apps.json file required?

@hughbarney
Copy link
Contributor

any screenshots ? Would love to see what this looks like ?

@HeiLaut
Copy link
Contributor Author

HeiLaut commented Dec 21, 2021

any screenshots ? Would love to see what this looks like ?

you can view the readme file, containing a screenshot, here:

https://github.com/HeiLaut/BangleApps/tree/master/apps/andark

Is the add_to_apps.json file required?

no it isn't required

@Didgeridoohan
Copy link
Contributor

Didgeridoohan commented Dec 22, 2021

I tested this and it looks absolutely lovely!

But, it's going to kill the battery since it's refreshing every second even with the screen locked and dimmed, even though it looks like you've covered that by trying to stop updates when the LCD is off. Does the lcdPower event even work on the Bangle.js 2, since the LCD is always on (doesn't seem like it)? Maybe the isLocked command and the lock event is better suited.

Also, a suggestion: only stop the seconds updating when the LCD is off and let minutes and hours keep updating.

Reasoning: I (and probably others) have my watch set to only unlock and light up the LCD on a rather more aggressive twist than default (to save the battery draining from unnecessarily turning on the LCD). From what I could see you (intend to) stop the entire clock updating whenever the LCD is off, which means that whenever I check the time without unlocking/turning on the screen the time shown wouldn't be correct...

@HeiLaut
Copy link
Contributor Author

HeiLaut commented Dec 22, 2021

I tested this and it looks absolutely lovely!

But, it's going to kill the battery since it's refreshing every second even with the screen locked and dimmed, even though it looks like you've covered that by trying to stop updates when the LCD is off. Does the lcdPower event even work on the Bangle.js 2, since the LCD is always on (doesn't seem like it)? Maybe the isLocked command and the lock event is better suited.

Also, a suggestion: only stop the seconds updating when the LCD is off and let minutes and hours keep updating.

Reasoning: I (and probably others) have my watch set to only unlock and light up the LCD on a rather more aggressive twist than default (to save the battery draining from unnecessarily turning on the LCD). From what I could see you (intend to) stop the entire clock updating whenever the LCD is off, which means that whenever I check the time without unlocking/turning on the screen the time shown wouldn't be correct...

thanks for the suggestions. I changed it, so the watch (bangle.js2) updates only after 60 seconds, when locked and hides the second hand.

can't test if it's working correkt on banglejs1
@HeiLaut
Copy link
Contributor Author

HeiLaut commented Dec 22, 2021

i'm new to the bangle js community and also on working with github. Don't know why checks failed, and don't know what to to next. eventually anybody can help me out?
thanks

@gfwilliams
Copy link
Member

Hi! Where it says 'Build Failed' you can click 'Details' then the highighted 'The Build' text on the next page. Looks like it's complaining about the icon. I think "icon": "andark_icon.png", should have been left as "icon": "app_icon.png", - but I'll merge and make that tweak now

@gfwilliams gfwilliams merged commit 544fcee into espruino:master Jan 4, 2022
@gfwilliams
Copy link
Member

I was wrong - there was just a space in "app_icon.js ". fixed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants