-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marioclock: use short date format from locale, take timeout from sett… #167
Conversation
Thanks - it's tricky about the timeout... Bangle.js keeps the screen on whenever there's a Maybe I could make that one of the |
@gfwilliams : Unfortunatly the few bytes more apparently means we get hit by "Upload Failed, got UNFINISHED STRING expected EOF" now. I only tested uploading the app with the IDE... I will try some changes and open a new pull request |
I'll fix that issue with the App Uploader today, so I wouldn't be too concerned. |
@DerGuteWolf How do I go about selecting the original date format? |
The setting is taking from the locale app, ie what is selected during installation/update of this app. |
Oh right, I might be missing something here, in |
@paulcockrell : Yes, the language to be used is not in settings but in the locale app. |
@DerGuteWolf Looks to me like I can't get the original date format back in that case, and am stuck with this short date. |
Not sure I understand your problem? You install the In terms of Date format, |
@paulcockrell : locale defines only two variants: short and long (and long is really long in some locales - but only some - and thus won't fit). The original format was a mixture between both and there is no support in locale to localize such an intermediate variant. Perhaps you should suggest adding a third variant to @gfwilliams . Alternativy we could first try long, remove the four-digit year and if it fits, use this and otherwise use the short version (also with four-digit year removed). |
My problem is I want to see the Day name and day number as I originally wrote it. The year is not something I need reminding of. |
@gfwilliams : Part of the problem here comes also from the fact, that esp the long versions are not consistent in the various locales, eg en_gb "Feb 28 2020" (which I would consider an intermediate variant as no weekday and month abbrev) vs de_de "Sonntag, 1. März 2020" (which is really the long variant, full weekday and full month). |
@paulcockrell: I understand, but this is unfortunatly currently not localisable.... |
@DerGuteWolf It's fine, I understand making it valid for various locales is important for other users. So I appreciate the change you put in. Maybe it's just me, but I do need reminding what the day of the week is, they all blend in to one :-) |
Take into account discussion from #167
…ings