-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[messageicons] Add Jira icon + color #2578
Conversation
Thanks but did this work when you tested it? I think you also need to add it to https://github.com/espruino/BangleApps/blob/5a2597ae5c03a34f50b344dad7dcd4d9944e2169/apps/messageicons/icons/icon_names.json and to re-run the script which regenerates the icons file |
I wasn't aware of the |
Added jira
Left a comment, to make it clearer that you should not modify "lib.js" directly, but to modify "generate.js" instead.
Now I'm not exactly sure how to run the generate.js file to get the updated version, I tried running the code on my Ubuntu (Windows Subsystem for Linux) with NodeJS installed but I haven't figured it all out. I'll try to get that done tonight. |
Thanks - I'll just run it here after merging |
Thank you! I'll figure it out on my end and make sure I can do it next time. |
Add an icon for Jira software notifications.