Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messageicons] Add Jira icon + color #2578

Merged
merged 9 commits into from
Feb 23, 2023
Merged

[messageicons] Add Jira icon + color #2578

merged 9 commits into from
Feb 23, 2023

Conversation

m-p-3
Copy link
Contributor

@m-p-3 m-p-3 commented Feb 15, 2023

Add an icon for Jira software notifications.

@gfwilliams
Copy link
Member

Thanks but did this work when you tested it?

I think you also need to add it to https://github.com/espruino/BangleApps/blob/5a2597ae5c03a34f50b344dad7dcd4d9944e2169/apps/messageicons/icons/icon_names.json and to re-run the script which regenerates the icons file

@gfwilliams gfwilliams marked this pull request as draft February 20, 2023 13:06
@m-p-3
Copy link
Contributor Author

m-p-3 commented Feb 21, 2023

I wasn't aware of the icon_names.json file, I'll fix that today.

Left a comment, to make it clearer that you should not modify "lib.js" directly, but to modify "generate.js" instead.
@m-p-3
Copy link
Contributor Author

m-p-3 commented Feb 22, 2023

Now I'm not exactly sure how to run the generate.js file to get the updated version, I tried running the code on my Ubuntu (Windows Subsystem for Linux) with NodeJS installed but I haven't figured it all out. I'll try to get that done tonight.

@gfwilliams
Copy link
Member

Thanks - I'll just run it here after merging

@gfwilliams gfwilliams marked this pull request as ready for review February 23, 2023 10:03
@gfwilliams gfwilliams merged commit c6a6056 into espruino:master Feb 23, 2023
gfwilliams added a commit that referenced this pull request Feb 23, 2023
@m-p-3
Copy link
Contributor Author

m-p-3 commented Feb 23, 2023

Thank you! I'll figure it out on my end and make sure I can do it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants