Merge pull request #9623 from ericchiang/grpc-logs

etcdctl/ctlv3/command: enable gRPC WARNING logs by default
etcd-io · Apr 25, 2018 · e73f909 · e73f909
2 parents 189d24e + 9ce295a
commit e73f909
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/etcdctl/ctlv3/command/global.go b/etcdctl/ctlv3/command/global.go
@@ -128,7 +128,9 @@ func clientConfigFromCmd(cmd *cobra.Command) *clientConfig {
 			fmt.Fprintf(os.Stderr, "%s=%v\n", flags.FlagToEnv("ETCDCTL", f.Name), f.Value)
 		})
 	} else {
-		clientv3.SetLogger(grpclog.NewLoggerV2(ioutil.Discard, ioutil.Discard, ioutil.Discard))
+		// Enable logging for WARNING and ERROR since these levels include issues with
+		// connecting to the server, such as TLS misconfiguration.
+		clientv3.SetLogger(grpclog.NewLoggerV2(ioutil.Discard, os.Stderr, os.Stderr))
 	}
 
 	cfg := &clientConfig{}