Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions workflow for 3.4 passed despite failures within tests #15487

Closed
jmhbnz opened this issue Mar 16, 2023 · 2 comments
Closed

Actions workflow for 3.4 passed despite failures within tests #15487

jmhbnz opened this issue Mar 16, 2023 · 2 comments
Assignees
@fuweid
Labels
area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@jmhbnz
Copy link
Member

jmhbnz commented Mar 16, 2023 •
edited
Loading

Which github workflows are flaking?

This workflow run succeeded despite me having errors with one of the tests defined: https://github.com/etcd-io/etcd/actions/runs/4433391180

Issue was with file tests/e2e/etcd_config_test.go

Which tests are flaking?

Specifically this job: https://github.com/etcd-io/etcd/actions/runs/4433391180/jobs/7778376779

Which finished with the following job output:

# go.etcd.io/etcd/tests/e2e [go.etcd.io/etcd/tests/e2e.test]
Error: tests/e2e/etcd_config_test.go:342:2: undefined: skipInShortMode
Error: tests/e2e/etcd_config_test.go:362:6: too many arguments in call to spawnCmd
	have ([]string, nil)
	want ([]string)
FAIL	go.etcd.io/etcd/tests/e2e [build failed]
FAIL

Github Action link

https://github.com/etcd-io/etcd/actions/runs/4433391180/jobs/7778376779

Reason for failure (if possible)

No response

Anything else we need to know?

Expectation is this kind of failure would cause the job to fail.

Relates to #15486
@fuweid
Copy link
Member

fuweid commented Mar 16, 2023

/assign

I'm debugging some flaky testcases in pipeline. Let me handle this. Thanks

@serathius serathius added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed type/flake labels Mar 17, 2023
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: use pipefail to show the error
529577a 
fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid mentioned this issue Mar 18, 2023
Merged
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: use pipefail to show the error
8ce498f 
fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: use pipefail to show the error
b6d7b5d 
fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: use pipefail to show the error
546f3df 
fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: enable pipefail mode for grpcproxy test
3e2d228 
By default, the pipefail is disabled. For instance, the commands should
return 1 as exit code, but we get zero. After pipefail enabled, it's
back to normal.

```bash
$ ( echo hello; exit 1 ) | tee 2>&1
hello
$ echo $?
0

$ set -o pipefail
$ ( echo hello; exit 122 ) | tee 2>&1
hello
$ echo $?
122
```

And the test.log is used to grep the error from a ton of messages. So
that we should `set +e` and set it back after egrep.

fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: enable pipefail mode for grpcproxy test
9d7354f 
By default, the pipefail is disabled. For instance, the commands should
return 1 as exit code, but we get zero. After pipefail enabled, it's
back to normal.

```bash
$ ( echo hello; exit 1 ) | tee 2>&1
hello
$ echo $?
0

$ set -o pipefail
$ ( echo hello; exit 122 ) | tee 2>&1
hello
$ echo $?
122
```

And the test.log is used to grep the error from a ton of messages. So
that we should `set +e` and set it back after egrep.

fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 18, 2023
@fuweid
fix: enable pipefail mode for grpcproxy test
91a101a 
By default, the pipefail is disabled. For instance, the commands should
return 1 as exit code, but we get zero. After pipefail enabled, it's
back to normal.

```bash
$ ( echo hello; exit 1 ) | tee 2>&1
hello
$ echo $?
0

$ set -o pipefail
$ ( echo hello; exit 122 ) | tee 2>&1
hello
$ echo $?
122
```

And the test.log is used to grep the error from a ton of messages. So
that we should `set +e` and set it back after egrep.

fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 22, 2023
@fuweid
fix: enable strict mode for CI
130ab5b 
fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Mar 22, 2023
@fuweid
fix: enable strict mode for CI
3fc5fbe 
fixes: etcd-io#15487

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid
Copy link
Member

fuweid commented May 14, 2023

Closed by #15504

@fuweid fuweid closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuweid fuweid

Labels
area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@serathius @fuweid @ahrtr @jmhbnz