clientv3/ordering: adjust violation count.

[johncming]

three changes

first:
func (c *Client) Endpoints() (eps []string) remove naked return

second:
Concurrent access is possible infunc (c *Client) Endpoints() (eps []string) , so mutex required.

etcd/clientv3/client.go

Lines 164 to 175 in ebb559a

	func (c *Client) Sync(ctx context.Context) error {
	mresp, err := c.MemberList(ctx)
	if err != nil {
	return err
	}
	var eps []string
	for _, m := range mresp.Members {
	eps = append(eps, m.ClientURLs...)
	}
	c.SetEndpoints(eps...)
	return nil
	}

third:
violationCount should reset after endpoints changed.

[codecov-io]

Codecov Report

Merging #10580 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10580      +/-   ##
==========================================
+ Coverage   71.63%    71.7%   +0.07%     
==========================================
  Files         393      393              
  Lines       36568    36574       +6     
==========================================
+ Hits        26195    26227      +32     
+ Misses       8538     8515      -23     
+ Partials     1835     1832       -3

Impacted Files	Coverage Δ
clientv3/client.go	80.22% <100%> (+0.11%)	⬆️
clientv3/ordering/util.go	100% <100%> (ø)	⬆️
etcdserver/api/v3rpc/lease.go	71.59% <0%> (-5.69%)	⬇️
pkg/logutil/zap_grpc.go	47.61% <0%> (-4.77%)	⬇️
pkg/testutil/recorder.go	77.77% <0%> (-3.71%)	⬇️
clientv3/concurrency/election.go	79.68% <0%> (-2.35%)	⬇️
clientv3/balancer/grpc1.7-health.go	58.13% <0%> (-1.17%)	⬇️
etcdserver/server.go	74.67% <0%> (-0.51%)	⬇️
etcdserver/api/rafthttp/stream.go	79.39% <0%> (-0.43%)	⬇️
clientv3/watch.go	92.4% <0%> (+0.63%)	⬆️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5acb4...ebb559a. Read the comment docs.

[xiang90]

@johncming

Can you separate this PR to two PRs? One for the locking thing, the other one for the ordering pkg? Thanks!

[johncming]

@johncming

Can you separate this PR to two PRs? One for the locking thing, the other one for the ordering pkg? Thanks!

OK. I will do it.

[jingyih]

cc @jpbetz

[xiang90]

@johncming can you update this one as the split PR is merged?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.