vendor: update boltdb #10808
Merged
vendor: update boltdb #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
1 similar comment
|
lgtm |
|
I will update the changelog accordingly. |
|
Do we want to backport this? Is the bug "rollback panic when freelist nosync is enabled" only in master? |
jingyih
added a commit
that referenced
this pull request
Jun 10, 2019
CHANGELOG-3.4: update from #10808
|
@jingyih I think we should backport it |
@WIZARD-CXY Thanks. Do you have bandwidth to help back porting? If not, I can do it tomorrow. |
|
@jingyih I think etcd 3.3 involves the nosync freelist feature. we can backport it to only v3.3 if I think it right. |
|
If the bug only appears after 870302a, then only 3.3 has it. |
|
yes |
|
For reference, bbolt is upgraded to v1.3.3 in 3.3 branch via #11056. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the boltdb dependency to v1.3.3. mainly solve the panic bug in boltdb @xiang90 @jingyih