Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: centralize configuration change application #10865

Merged
merged 2 commits into from
Jul 3, 2019
Merged

raft: centralize configuration change application #10865

merged 2 commits into from
Jul 3, 2019

Commits on Jul 3, 2019

  1. raft: centralize configuration change application 

    Put all the logic related to applying a configuration change in one
place in preparation for adding joint consensus.

This inspired various TODOs.

I had to rewrite TestSnapshotSucceedViaAppResp since it was relying
on a snapshot applied to the leader, which is now prevented.
    @tbg
    tbg committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    b171e1c View commit details
    Browse the repository at this point in the history

  2. raft/tracker: pull Voters and Learners into Config struct 

    This is helpful to quickly print the configuration log messages without
having to specify Voters and Learners separately.

It will also come in handy for joint quorums because it allows holding
on to voters and learners as a unit, which is useful for unit testing.
    @tbg
    tbg committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    6697adf View commit details
    Browse the repository at this point in the history