Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #12000 #12021

Conversation

RainbowMango
Copy link

Cherry pick of #12000 on release-3.4.

#12000: etcdserver: change protobuf field type from int to int64

@RainbowMango
Copy link
Author

I guess CI failure is fake. Don't know how re-trigger them.

cc @YoyinZyc @jingyih @xiang90

Seems there is another similar issue, please refer to kubernetes/kubernetes#92070 (comment).

@YoyinZyc
Copy link
Contributor

LGTM

@Rajalakshmi-Girish
Copy link
Contributor

@RainbowMango any update on this PR?

@RainbowMango
Copy link
Author

No update. Waiting for maintainer review and approval.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@spzala
Copy link
Member

spzala commented Jul 13, 2020

/cc @jpbetz

@jingyih
Copy link
Contributor

jingyih commented Jul 16, 2020

We just merged #12106 which is duplicate of this PR. So closing this. Thanks!

@jingyih jingyih closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants