etcdserver, wal: Fix tests unintended CASTing of int->String. #12198
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20200803-int-to-string-test-fix
branch
2 times, most recently
from
f6c7eeb
to
1050e0e
Compare
|
\cc @jpbetz |
… int to String. Fixes following problems during "./etcd# go test ./..." > go.etcd.io/etcd/v3/etcdserver/api/v2store_test etcdserver/api/v2store/store_test.go:847:24: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) > go.etcd.io/etcd/v3/wal wal/wal_test.go:242:68: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
ptabor
force-pushed
the
20200803-int-to-string-test-fix
branch
from
1050e0e
to
00de56a
Compare
|
\cc @jingyih - could you, pls, review / merge |
spzala
reviewed
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following problems during "./etcd# go test ./..." build: