--experimental-memory-mlock support #12750
Merged
+104
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20210306-mlock
branch
3 times, most recently
from
8bf7385
to
3d476df
Compare
The flag protects etcd memory from being swapped out to disk. This can happen in memory constrained systems where mmaped bbolt area is natural condidate for swapping out. This flag should provide better tail latency on the cost of higher RSS ram usage. If the experiment is successful, the logic should get moved into bbolt layer, where we can protect specific bbolt instances (e.g. avoid protecting both during defragmentation).
wpedrak
added a commit
to wpedrak/bbolt
that referenced
this pull request
Apr 22, 2021
`Mlock` flag will cause mlock on db file which will prevent memory swapping of it. Motivation of this commit (etcd): etcd-io/etcd#12750
|
Hi @ptabor @serathius either I don't have complete context or the flag is missing from |
passiondev2024
added a commit
to passiondev2024/bbolt
that referenced
this pull request
Mar 20, 2024
`Mlock` flag will cause mlock on db file which will prevent memory swapping of it. Motivation of this commit (etcd): etcd-io/etcd#12750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag protects etcd memory from being swapped out to disk.
This can happen in memory constrained systems where mmaped bbolt
area is natural candidate for swapping out.
This flag should provide better tail latency on the cost of higher RSS
ram usage. If the experiment is successful, the logic should get moved
into bbolt layer, where we can protect specific bbolt instances
(e.g. avoid protecting both during defragmentation).