Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: unlimit the recv msg size of grpc-gateway #13077

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

spacewander
Copy link
Contributor

Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix #12576

Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
@spacewander
Copy link
Contributor Author

I am not familiar with etcd's test so I don't know how to test it in the CI.
I test it locally and it works well.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.49%. Comparing base (af6f3dc) to head (576861e).
Report is 4677 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13077      +/-   ##
==========================================
- Coverage   67.90%   61.49%   -6.41%     
==========================================
  Files         437      418      -19     
  Lines       33831    33009     -822     
==========================================
- Hits        22973    20299    -2674     
- Misses       8895    10637    +1742     
- Partials     1963     2073     +110     
Flag Coverage Δ
all 61.49% <100.00%> (-6.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacewander
Copy link
Contributor Author

Ping @ptabor @gyuho

@membphis
Copy link

Very useful PR, looking forward to being merged soon

Copy link
Contributor

@tangcong tangcong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
The etcd gRPC Server MaxSendMsgSize is also math.MaxInt32. @gyuho PTAL.

@gyuho gyuho merged commit 5667803 into etcd-io:main Jun 10, 2021
@gyuho
Copy link
Contributor

gyuho commented Jun 10, 2021

@spacewander @tangcong Sorry for the delay. Can we also backport to 3.5?

@tangcong
Copy link
Contributor

tangcong commented Jun 10, 2021

#13099 #13100 done. APISIX and other projects are currently mainly using etcd 3.4, and it is better that we can also backport it to 3.4. thanks @gyuho

@wayne-cheng
Copy link

@tangcong There are still many users using the version 3.3,could you also backport it to 3.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to configure grpc.MaxCallRecvMsgSize
6 participants