Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 3.5]: server/auth: enable tokenProvider if recoved store enables auth #13205

Merged
merged 1 commit into from
May 6, 2022

Conversation

cfz
Copy link
Contributor

@cfz cfz commented Jul 11, 2021

backport #13172
we would like to have this fix in release 3.5
cc @mitake @spzala

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @cfz

Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mitake
Copy link
Contributor

mitake commented Jul 13, 2021

@hexfusion could you check it's ok to merge this PR to the stable branch?

@cfz
Copy link
Contributor Author

cfz commented Jul 20, 2021

@hexfusion could you have a look? and as well as #13206 ?

@stale
Copy link

stale bot commented Oct 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 18, 2021
@stale stale bot closed this Nov 8, 2021
@ahrtr ahrtr reopened this May 5, 2022
@stale stale bot removed the stale label May 5, 2022
@ahrtr
Copy link
Member

ahrtr commented May 5, 2022

@cfz Could you please rebase this PR? Sorry for the delay of reviewing this PR.

we found a lease leak issue:
if a new member(by member add) is recovered by snapshot, and then
become leader, the lease will never expire afterwards. leader will
log the revoke failure caused by "invalid auth token", since the
token provider is not functional, and drops all generated token
from upper layer, which in this case, is the lease revoking
routine.
@cfz
Copy link
Contributor Author

cfz commented May 6, 2022

@ahrtr done, great to hear the plan to restart active maintenance for release 3.4/3/5

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

This PR should be ready to be merged. cc @mitake @ptabor @serathius @spzala

@ptabor ptabor merged commit b57881a into etcd-io:release-3.5 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants