Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Migrate kv delete tests to common framework. #13753

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

serathius
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #13753 (e3bc51c) into main (d2e5a8c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e3bc51c differs from pull request most recent head a60abee. Consider uploading reports for the commit a60abee to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13753      +/-   ##
==========================================
- Coverage   72.63%   72.62%   -0.01%     
==========================================
  Files         467      467              
  Lines       38280    38280              
==========================================
- Hits        27804    27801       -3     
- Misses       8666     8673       +7     
+ Partials     1810     1806       -4     
Flag Coverage Δ
all 72.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
client/pkg/v3/testutil/recorder.go 76.27% <0.00%> (-3.39%) ⬇️
server/storage/mvcc/watchable_store.go 85.14% <0.00%> (-2.90%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-1.67%) ⬇️
client/v3/leasing/kv.go 89.70% <0.00%> (-1.67%) ⬇️
client/v3/op.go 74.32% <0.00%> (-1.15%) ⬇️
server/etcdserver/api/v3rpc/watch.go 85.90% <0.00%> (-0.68%) ⬇️
client/v3/watch.go 92.77% <0.00%> (-0.41%) ⬇️
server/etcdserver/server.go 84.19% <0.00%> (-0.33%) ⬇️
server/etcdserver/v3_server.go 79.18% <0.00%> (+0.70%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e5a8c...a60abee. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @serathius

@spzala spzala merged commit 8ac44ff into etcd-io:main Mar 3, 2022
@tjungblu tjungblu mentioned this pull request Jul 27, 2022
@serathius serathius deleted the common-delete branch June 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants