tests: Migrate noquorum kv tests to common framework #13754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
common-noquorum
branch
from
cd303f5
to
c7041be
Compare
Codecov Report
@@ Coverage Diff @@
## main #13754 +/- ##
==========================================
- Coverage 72.56% 72.50% -0.07%
==========================================
Files 467 467
Lines 38280 38280
==========================================
- Hits 27777 27754 -23
- Misses 8720 8735 +15
- Partials 1783 1791 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
serathius
force-pushed
the
common-noquorum
branch
from
c7041be
to
44aad46
Compare
ahrtr
approved these changes
Mar 22, 2022
| Client() Client | ||
| Start() error | ||
| Stop() |
There was a problem hiding this comment.
Is it possible that the e2e or integration somehow fail to stop a member? Does it make sense to return an error?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ptabor @spzala @ahrtr