Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Migrate completion tests to common framework #13825

Closed
wants to merge 1 commit into from

Conversation

kkkkun
Copy link
Contributor

@kkkkun kkkkun commented Mar 20, 2022

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #13825 (0a33d5c) into main (1b208aa) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13825      +/-   ##
==========================================
- Coverage   72.63%   72.54%   -0.10%     
==========================================
  Files         467      467              
  Lines       38280    38280              
==========================================
- Hits        27806    27769      -37     
- Misses       8686     8710      +24     
- Partials     1788     1801      +13     
Flag Coverage Δ
all 72.54% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/v3/txn.go 73.33% <0.00%> (-26.67%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
server/etcdserver/api/v3rpc/member.go 93.54% <0.00%> (-3.23%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
client/v3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0.00%> (-1.74%) ⬇️
server/etcdserver/api/v3rpc/maintenance.go 76.71% <0.00%> (-1.37%) ⬇️
client/v3/op.go 74.32% <0.00%> (-1.15%) ⬇️
server/storage/mvcc/watchable_store.go 88.76% <0.00%> (-1.09%) ⬇️
client/v3/leasing/kv.go 90.36% <0.00%> (-1.00%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b208aa...0a33d5c. Read the comment docs.

@kkkkun kkkkun force-pushed the completion_test branch 2 times, most recently from f7617e5 to 35db9ac Compare March 20, 2022 10:01
Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR refactors the code, however doesn't do the test migration. Goal of the migration is to use single framework for unit and integration tests.

Please skip the tests that operate on binaries for now.

@kkkkun
Copy link
Contributor Author

kkkkun commented Mar 21, 2022

This PR refactors the code, however doesn't do the test migration. Goal of the migration is to use single framework for unit and integration tests.

Please skip the tests that operat on binaries for now.

That's ok.

@serathius
Copy link
Member

I'm ok with the refactor, however let's leave the code in tests/e2e directory.

@kkkkun kkkkun closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants