-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Migrate member tests to common framework #14271
Conversation
tests/common/member_test.go
Outdated
if gotNum == 0 { | ||
t.Fatalf("number of members is 0") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is not needed as you check expectNum != gotNum
above. expectNum
is guaranteed to be at least 1.
Please fix DCO by running |
Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #14271 +/- ##
==========================================
- Coverage 75.40% 75.23% -0.17%
==========================================
Files 456 456
Lines 36919 36919
==========================================
- Hits 27838 27776 -62
- Misses 7345 7397 +52
- Partials 1736 1746 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Context #13637