-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Migrate member list tests to common framework #14278
Conversation
I would recommend to not do everything in one PR. If you can migrate one test independently it would be faster for us to iterate. |
f71b24c
to
3af9f2d
Compare
3af9f2d
to
2a9f444
Compare
sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes me super excited. With only couple of lines the test is much more readable as we reuse so much code.
For context this is the old test:
func ctlV3MemberList(cx ctlCtx) error {
cmdArgs := append(cx.PrefixArgs(), "member", "list")
lines := make([]string, cx.cfg.ClusterSize)
for i := range lines {
lines[i] = "started"
}
return e2e.SpawnWithExpects(cmdArgs, cx.envMap, lines...)
}
DCO failed after adding the suggestion commit. Can you squash the commits in PR? |
Signed-off-by: Clark <fwyongxing@gmail.com>
Sure |
e21d142
to
13d20f8
Compare
Codecov Report
@@ Coverage Diff @@
## main #14278 +/- ##
==========================================
- Coverage 75.52% 75.35% -0.18%
==========================================
Files 456 456
Lines 37037 37037
==========================================
- Hits 27973 27909 -64
- Misses 7322 7373 +51
- Partials 1742 1755 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Context #13637
Signed-off-by: Clark fwyongxing@gmail.com