rafthttp: test multiple transport removes #14284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test to verify multiple transport removes does not create an issue. Signed-off-by: Austin Benoit <22805659+AustinBenoit@users.noreply.github.com>
ahrtr
approved these changes
Jul 31, 2022
There was a problem hiding this comment.
LGTM
Thank you @AustinBenoit
Just an unrelated minor comment, you might want to configure your username and email in git. FYI. https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test to verify multiple transport removes does not create an issue.
Created a unit test as a part of 13715
Signed-off-by: Austin Benoit 22805659+AustinBenoit@users.noreply.github.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.