[3.5] Refactor the keepAliveListener and keepAliveConn #14366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `net.TCPConn` supports `SetKeepAlive` and `SetKeepAlivePeriod` by default, so if you want to warp multiple layers of net.Listener, the `keepaliveListener` should be the one which is closest to the original `net.Listener` implementation, namely `TCPListener`. Also refer to etcd-io#14356 Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Aug 21, 2022
…eListener and keepAliveConn Refer to etcd-io#14366, Also refer to etcd-io#14356 Signed-off-by: Benjamin Wang <wachao@vmware.com>
spzala
approved these changes
Aug 24, 2022
|
This is just a backport PR, so let me merge it. If there are any other comments, we can address them in the main branch firstly. |
|
Thanks @spzala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially cherry pick #14356 to 3.5.
When starting etcd using
./etcd --socket-reuse-address --socket-reuse-port, actually etcd setting the SetKeepAlive or SetKeepAlivePeriod fails, but the current code ignores the errors. This issue can happen on both Linux and Mac.Only
net.TCPConnsupportsSetKeepAliveandSetKeepAlivePeriodby default, so if you want to warp multiple layers of net.Listener,
the
keepaliveListenershould be the one which is closest to theoriginal
net.Listenerimplementation, namelyTCPListener.Signed-off-by: Benjamin Wang wachao@vmware.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @spzala @serathius @ptabor