etcdserver: nil-logger issue fix for version 3.4 #14420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v3.5 it is assumed that the logger should not be nil, however it is still a case in v3.4. The PR targeted to v3.5 was backported to 3.4 and that's why it's possible to get panic on nil logger in 3.4. This commit fixed this issue. Fixes etcd-io#14402 Signed-off-by: Vladimir Sokolov <vsvastey@gmail.com>
vsvastey
force-pushed
the
usr/vsvastey/nil-logger
branch
from
4d8c7e3
to
38342e8
Compare
|
@ahrtr I will send to my team for a test. |
|
@ahrtr I can confirm it works after I had a quick test on my own cluster with the manually built etcd including the current PR. Build info: I have no name!@autovmCOS76VM01:/> etcd --version commit 38342e8 (HEAD -> release-3.4) |
|
Thank you @JohnJAS ! |
ahrtr
approved these changes
Sep 5, 2022
|
@vsvastey Please add one changelog item into CHANGELOG-3.4.md. You can add one more section for 3.4.21. |
|
FYI. Updated the changelog in #14430 |
This was referenced Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3.5 it is assumed that the logger should not be nil, however it is
still a case in v3.4. The PR targeted to v3.5 was backported to 3.4 and
that's why it's possible to get panic on nil logger in 3.4. This commit
fixed this issue.
Fixes #14402