Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linearizability issue14890 #14904

Closed
wants to merge 3 commits into from

Conversation

serathius
Copy link
Member

cc @ahrtr @ptabor @geetasg @tjungblu @aphyr

Failed attempt to try reproducing #14890

I switched linearization model to append one resembling Jepsen https://jepsen.io/analyses/etcd-3.4.3#append

For now use single key and validates exact contents.
In loop each client:

  • Read the value of key
  • Create Txn if value didn't change, put original value appended with unique identifier.

This approach has one advantage that failed requests can be ignored. Model doesn't check exact requests, just ensures that prefix matches.

@aphyr From what I understood (don't know closure at all), one difference with append flow is that Jepsen compares modRevision in Txn instead value. Do you see any other differences or suggestions?

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2023
@serathius
Copy link
Member Author

No longer needed with TXN tests present.

@serathius serathius closed this Mar 18, 2023
@serathius serathius deleted the linearizability-issue14890 branch June 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant