mvcc: update minRev when watcher stays synced #15439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: during restore in watchableStore.Restore, synced watchers are moved to unsynced. minRev will be behind since it's not updated when watcher stays synced. Solution: update minRev fixes: etcd-io#15271 Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
|
@serathius I've tested that this fixes https://github.com/etcd-io/etcd/pull/15273/files I've marked this PR as draft because I'm not yet fluent with all logic for syncWatchers. Also, I'd like to add an integration test. For ref: Restore logic was added here |
|
We should probably add a test case to ensure the coverage. |
|
cc @logicalhan |
|
Any progress? |
|
Confirmed that this fixes #15271 |
|
Created #15492 based on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: during restore in watchableStore.Restore, synced watchers are moved to unsynced. minRev will be behind since it's not updated when watcher stays synced.
Solution: update minRev
fixes: #15271
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.