[3.5] server/embed: fix data race when start insecure grpc #15517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two goroutines accessing the `gs` grpc server var. Before insecure `gs` server start, the `gs` can be changed to secure server and then the client will fail to connect to etcd with insecure request. It is data-race. We should use argument for reference in the new goroutine. fix: etcd-io#15495 Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit a9988e2) Signed-off-by: Wei Fu <fuweid89@gmail.com>
serathius
approved these changes
Mar 20, 2023
ahrtr
approved these changes
Mar 20, 2023
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Jul 26, 2023
[3.5] server/embed: fix data race when start insecure grpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two goroutines accessing the
gsgrpc server var. Before insecuregsserver start, thegscan be changed to secure server and then the client will fail to connect to etcd with insecure request. It is data-race. We should use argument for reference in the new goroutine.fix: #15495
(cherry picked from commit a9988e2)
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cherry-pick: #15509